From: Adrian Ratiu Date: Sun, 11 Jan 2026 14:12:18 GMT Subject: Re: [PATCH v2][next] hook: check for NULL pointer before deref Message-ID: <87ecnws0fx.fsf@gentoo.mail-host-address-is-not-set> In-Reply-To: On Fri, 09 Jan 2026, Junio C Hamano wrote: > Adrian Ratiu writes: > >> Fix a compiler warning (-Werror=analyzer-deref-before-check) due to >> dereferencing the options pointer before NULL checking it. >> >> In practice run_hooks_opt() is never called with a NULL opt struct, >> so this just fixes the code to not trigger the warning anymore. >> >> The NULL check is kept as-is because some future patches might end up >> calling run_hooks_opt with a NULL opt struct, which is clearly a bug. >> >> While at it, also fix the BUG message function name. >> >> Reported-by: correctmost >> Suggested-by: Patrick Steinhardt >> Signed-off-by: Adrian Ratiu >> --- >> This is based on next, because it fixes a warning introduced in next. > > Actually the problematic topic has been in 'master' for a few days > already, isn't it? I'd apply directly on top of ar/run-comand-hook > topic. Yes, that is correct, the commits landed in master so this patch applies cleanly there as well (just double checked to confirm). Thanks!