From: Adrian Ratiu <adrian.ratiu@collabora.com>
Date: Tue, 24 Mar 2026 19:23:31 GMT
Subject: Re: [PATCH v2 10/10] hook: show disabled hooks in "git hook list"
Message-ID: <87ecl9c9qk.fsf@collabora.com>
In-Reply-To: <acJNdKyz-ISsq4fJ@pks.im>

On Tue, 24 Mar 2026, Patrick Steinhardt <ps@pks.im> wrote:
> On Fri, Mar 20, 2026 at 01:52:11PM +0200, Adrian Ratiu wrote:
>> diff --git a/hook.c b/hook.c
>> index aa08c38c27..0e09b9a2bb 100644
>> --- a/hook.c
>> +++ b/hook.c
>> @@ -119,6 +119,7 @@ static void list_hooks_add_default(struct repository *r, const char *hookname,
>>  struct hook_config_cache_entry {
>>  	char *command;
>>  	enum config_scope scope;
>> +	unsigned int disabled:1;
>>  };
>>  
>>  /*
>
> Curious, this is now a single-bit int. I still would have expected a
> proper bool here :)

Yes, I did it this way because the parallel series also adds another
1-bit int after this one. :) 

I'll make both these a proper bool as you requested in the other series
as well. I don't have any preference and am ok with bool as well. :)