From: Thomas Rast <trast@inf.ethz.ch>
Date: Thu, 30 May 2013 14:35:29 GMT
Subject: Re: [PATCH] test: fix post rewrite hook report
Message-ID: <87d2s8fscu.fsf@linux-k42r.v.cablecom.net>
In-Reply-To: <1369921595-30514-1-git-send-email-felipe.contreras@gmail.com>

Felipe Contreras <felipe.contreras@gmail.com> writes:

> First expected, then actual.

Ack.  That is the prevalent (almost universal, but not quite) style.

> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
> ---
>  t/t5407-post-rewrite-hook.sh | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/t/t5407-post-rewrite-hook.sh b/t/t5407-post-rewrite-hook.sh
> index baa670c..ea2e0d4 100755
> --- a/t/t5407-post-rewrite-hook.sh
> +++ b/t/t5407-post-rewrite-hook.sh
> @@ -31,8 +31,8 @@ clear_hook_input () {
>  }
>  
>  verify_hook_input () {
> -	test_cmp "$TRASH_DIRECTORY"/post-rewrite.args expected.args &&
> -	test_cmp "$TRASH_DIRECTORY"/post-rewrite.data expected.data
> +	test_cmp expected.args "$TRASH_DIRECTORY"/post-rewrite.args &&
> +	test_cmp expected.data "$TRASH_DIRECTORY"/post-rewrite.data
>  }
>  
>  test_expect_success 'git commit --amend' '

-- 
Thomas Rast
trast@{inf,student}.ethz.ch