From: Giuseppe Scrivano Date: Sat, 26 Sep 2009 21:42:33 GMT Subject: Re: [PATCH] Remove various dead assignments and dead increments found by the clang static analyzer Message-ID: <87bpkxcrhy.fsf@master.homenet> In-Reply-To: <3f4fd2640909261420h2588df4cld8dd3e49f9654e9e@mail.gmail.com> Reece Dunn writes: >> There is exactly one caller, and it doesn't care about the return code >> for the reasons mentioned above. > > Including being called from a script? I agree, if something goes wrong then it should be reported. The same applies to the `run_receive_hook' return code that is not checked in `cmd_receive_pack'. Considering you want to keep the current source code invariants, and I don't have any objection to it, probably the only assignment that can be removed is the following one: >From f8dd14bf4c3f3e132f6a8e13bf3e2fc575a804b1 Mon Sep 17 00:00:00 2001 From: Giuseppe Scrivano Date: Sat, 26 Sep 2009 23:23:13 +0200 Subject: [PATCH] Remove a dead assignment found by the clang static analyzer --- http-fetch.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/http-fetch.c b/http-fetch.c index e8f44ba..6879904 100644 --- a/http-fetch.c +++ b/http-fetch.c @@ -3,7 +3,6 @@ int main(int argc, const char **argv) { - const char *prefix; struct walker *walker; int commits_on_stdin = 0; int commits; @@ -19,7 +18,7 @@ int main(int argc, const char **argv) int get_verbosely = 0; int get_recover = 0; - prefix = setup_git_directory(); + setup_git_directory(); git_config(git_default_config, NULL); -- 1.6.3.3