From: Štěpán Němec <stepan.nemec@gmail.com>
Date: Fri, 08 Oct 2010 17:57:15 GMT
Subject: Re: [PATCH 2/6] Fix odd markup in --diff-filter documentation
Message-ID: <87bp74tvno.fsf@gmail.com>
In-Reply-To: <20101008173941.GA13738@burratino>

Jonathan Nieder <jrnieder@gmail.com> writes:

> Štěpán Němec wrote:
>
>> --- a/Documentation/diff-options.txt
>> +++ b/Documentation/diff-options.txt
>> @@ -248,13 +248,13 @@ endif::git-log[]
>>  	If `n` is specified, it has the same meaning as for `-M<n>`.
>>  
>>  ifndef::git-format-patch[]
>> ---diff-filter=[ACDMRTUXB*]::
>> +--diff-filter=<spec>::
>
> Maybe something like
>
> --diff-filter=((A|C|D|M|R|T|U|X|B)...[*])
>
> to keep the overview while following the conventions you've set out?

Looks good to me as well, thanks.

> Strictly speaking, --diff-filter= (with empty argument) is allowed, too,
> but I don't know if it's worth fitting that in.

If it provides some kind of useful behaviour (I don't know and you
didn't clarify that either), then it should be documented I guess?

Štěpán