From: Kyle Meyer <kyle@kyleam.com>
Date: Sat, 07 Jan 2017 01:19:53 GMT
Subject: Re: [PATCH] branch_get_push: do not segfault when HEAD is detached
Message-ID: <87bmvjll8m.fsf@kyleam.com>
In-Reply-To: <20170107011138.uuy6ob234kyy3y4e@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

> On Fri, Jan 06, 2017 at 08:09:32PM -0500, Kyle Meyer wrote:
>
>> > $ git grep -c HEAD^{} junio/pu -- t/
>> > junio/pu:t/t3200-branch.sh:3
>> >
>> > Maybe use HEAD^0 just for consistency?
>>
>> Yes, thanks for pointing that out.
>
> The other option is just "git checkout --detach", which is also used in
> the test suite. I tend to prefer it because it's a little more obvious
> to a reader.

True, that does seem clearer.  Seems I should've waited a bit before
sending out v2.

--
Kyle