From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Sun, 13 Jun 2021 13:28:58 GMT
Subject: Re: [PATCH 1/4] test-lib-functions: introduce test_line_count_cmd
Message-ID: <87bl8928q9.fsf@evledraar.gmail.com>
In-Reply-To: <20210612042755.28342-2-congdanhqx@gmail.com>


On Sat, Jun 12 2021, Đoàn Trần Công Danh wrote:

> +	   { test "x$1" = "x!" && test $# = 1 ; }
> [...]
> +	if test "x$1" = "x!" 

We don't use this test idiom in other places, it's OK to just use "$1" =
"!". I think we're past whatever portability concern made that popular
in some older shell code in the wild.