From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Thu, 01 Jul 2021 23:15:13 GMT
Subject: Re: [PATCH v3 27/34] t7527: create test for fsmonitor--daemon
Message-ID: <87bl7lbp72.fsf@evledraar.gmail.com>
In-Reply-To: <99279c0ebd2b36fe276301f018ca4e24e4cdff36.1625150864.git.gitgitgadget@gmail.com>


On Thu, Jul 01 2021, Jeff Hostetler via GitGitGadget wrote:

> +	grep \"event\":\"start\".*\"fsmonitor--daemon\" .git/trace_implicit_1
> +'
> +
> +test_expect_success 'status implicitly starts daemon' '
> +	test_when_finished redundant_stop_daemon &&
> +
> +	test_must_fail git fsmonitor--daemon status &&
> +
> +	GIT_TRACE2_EVENT="$(pwd)/.git/trace_implicit_2" \
> +		git status >actual &&
> +
> +	git fsmonitor--daemon status &&
> +	test_might_fail git fsmonitor--daemon stop &&
> +
> +	grep \"event\":\"start\".*\"fsmonitor--daemon\" .git/trace_implicit_2
> +'

Seems like this and test_region could eventually be factored into some
common function that would be more flexible about grabbing trace2 data.