From: Toon Claes Date: Mon, 04 May 2026 11:46:55 GMT Subject: Re: [PATCH v2 4/8] promisor-remote: add 'local_name' to 'struct promisor_info' Message-ID: <87bjevs8gg.fsf@toon--20250203-5JQV3.mail-host-address-is-not-set> In-Reply-To: <20260427124108.3524129-5-christian.couder@gmail.com> Christian Couder writes: > In a following commit, we will store promisor remote information under > a remote name different than the one the server advertised. > > To prepare for this change, let's add a new 'char *local_name' member > to 'struct promisor_info', and let's update the related functions. > > While at it, let's also add a small promisor_info_internal_name() > helper that returns `local_name` when set, `name` otherwise, and let's > use this small helper in promisor_store_advertised_fields() and in the > post-loop of filter_promisor_remote() so that lookups against the local > repo configuration use the right name. It seems the `local_name` doesn't get filled in yet, so because promisor_info_internal_name() falls back to `name` there is no functional change in this commit. Okay. -- Cheers, Toon