From: Pat Thoyts Date: Wed, 17 Mar 2010 15:20:03 GMT Subject: [PATCH 2/2] Report errors when failing to launch the html browser in mingw. Message-ID: <87aau7dkon.fsf@fox.patthoyts.tk> The mingw function to launch the system html browser is silent if the target file does not exist leaving the user confused. Make it display something. Signed-off-by: Pat Thoyts --- compat/mingw.c | 7 +++++-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/compat/mingw.c b/compat/mingw.c index 9c10a4c..d6539ef 100644 --- a/compat/mingw.c +++ b/compat/mingw.c @@ -1548,6 +1548,7 @@ void mingw_open_html(const char *unixpath) const char *, const char *, const char *, INT); T ShellExecute; HMODULE shell32; + int r; shell32 = LoadLibrary("shell32.dll"); if (!shell32) @@ -1557,9 +1558,11 @@ void mingw_open_html(const char *unixpath) die("cannot run browser"); printf("Launching default browser to display HTML ...\n"); - ShellExecute(NULL, "open", htmlpath, NULL, "\\", 0); - + r = (int)ShellExecute(NULL, "open", htmlpath, NULL, "\\", SW_SHOWNORMAL); FreeLibrary(shell32); + if (r < 33) { + die("failed to launch browser for %.*s", MAX_PATH, unixpath); + } } int link(const char *oldpath, const char *newpath) -- 1.7.0.2.msysgit.0.3.g3c992.dirty