From: Ævar Arnfjörð Bjarmason Date: Tue, 28 Aug 2018 20:14:28 GMT Subject: Re: [PATCH v4 4/6] tests: use shorter here-docs in chainlint.sed for AIX sed Message-ID: <87a7p6dza3.fsf@evledraar.gmail.com> In-Reply-To: On Fri, Aug 24 2018, Eric Sunshine wrote: > On Fri, Aug 24, 2018 at 11:20 AM Ævar Arnfjörð Bjarmason > wrote: >> Improve the portability of chainlint by using shorter here-docs. On >> AIX sed will complain about: >> >> sed: 0602-417 The label :hereslurp is greater than eight >> characters > > Shortening the names makes them ugly and often unreadable. That's not > a complaint with this patch; just a general observation regarding > 8-byte limitation with this platform's "sed" (and POSIX). See a few > suggested improvements below, but probably not worth a re-roll. > >> This, in combination with the previous fix to this file makes >> GIT_TEST_CHAIN_LINT=1 (which is the default) working again on AIX >> without issues, and the "gmake check-chainlint" test also passes. >> >> Signed-off-by: Ævar Arnfjörð Bjarmason > > FWIW, > Acked-by: Eric Sunshine > >> diff --git a/t/chainlint.sed b/t/chainlint.sed >> -:checkchain >> +:chkchn > > ":chkchain" > >> # found incomplete line "...\" -- slurp up next line >> -:incomplete >> +:icmplte > > ":fold" (for "fold out NL") > >> # found nested multi-line "(...\n...)" -- pass through untouched >> -:nestslurp >> +:nstslurp > > ":nesteat" > >> -:nestcontinue >> +:nstcnt > > ":nestcont" > >> -:nestclose >> +:nstclose > > ":nestend" or ":endnest" > >> # found closing ")" on own line -- drop "suspect" from final line of subshell >> # since that line legitimately lacks "&&" and exit subshell loop >> -:closesolo >> +:clssolo > > ":endsolo" I was meaning to get to this with a re-roll, but since this is already in next & these label renames seem cosmetic, it seems better to do this after 2.19, i.e. the compiler doesn't care about the specific names, but shortening them to <=8 fixes the bug.