From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Sat, 24 Nov 2018 19:27:52 GMT
Subject: Re: [PATCH v3 3/8] refs: new ref types to make per-worktree refs visible to all worktrees
Message-ID: <87a7ly1djb.fsf@evledraar.gmail.com>
In-Reply-To: <20181021080859.3203-4-pclouds@gmail.com>


On Sun, Oct 21 2018, Nguyễn Thái Ngọc Duy wrote:

This change has a regression in 2.20:

> [...]
>  static void files_reflog_path(struct files_ref_store *refs,
>  			      struct strbuf *sb,
>  			      const char *refname)
> @@ -158,6 +178,9 @@ static void files_reflog_path(struct files_ref_store *refs,
>  	case REF_TYPE_PSEUDOREF:
>  		strbuf_addf(sb, "%s/logs/%s", refs->gitdir, refname);
>  		break;
> +	case REF_TYPE_OTHER_PSEUDOREF:
> +	case REF_TYPE_MAIN_PSEUDOREF:
> +		return files_reflog_path_other_worktrees(refs, sb, refname);
>  	case REF_TYPE_NORMAL:
>  		strbuf_addf(sb, "%s/logs/%s", refs->gitcommondir, refname);
>  		break;

SunCC on Solaris hard errors on this:

    "refs/files-backend.c", line 183: void function cannot return value

Needs to be files...(); break; instead.