From: Toon Claes Date: Wed, 23 Apr 2025 14:12:13 GMT Subject: Re: [PATCH v3 0/5] meson: wire up support for benchmarks Message-ID: <87a587ezlu.fsf@iotcl.com> In-Reply-To: <20250422-pks-meson-benchmarks-v3-0-7aad68bac6fd@pks.im> Patrick Steinhardt writes: > Hi, > > this small patch series implements support for running our benchmarks in > "t/perf" via Meson. The series does not aim to replace "t/perf/run", > which is more fully-featured and allows running benchmarks against > multiple different trees. Instead, this series only allows running the > benchmarks against the current tree. Users are thus expected to continue > using "t/perf/run" for more advanced usecases. > > Changes in v2: > - Adapt "aggregate.perl" to use a "/usr/bin/env perl" shebang. > - Link to v1: https://lore.kernel.org/r/20250331-pks-meson-benchmarks-v1-0-b2ace85616a3@pks.im > > Changes in v3: > - Document how to run benchmarks in "meson.build". Thanks for adding this. I have no further comments. I approve. -- Toon