From: Toon Claes <toon@iotcl.com>
Date: Fri, 16 Jan 2026 13:11:39 GMT
Subject: Re: [PATCH v2 3/3] last-modified: verify revision argument is a commit-ish
Message-ID: <87a4ydk8hg.fsf@iotcl.com>
In-Reply-To: <bc0db8d5-3c5f-4dd4-9c35-ccb02a6bf5c9@app.fastmail.com>

"Kristoffer Haugsbakk" <kristofferhaugsbakk@fastmail.com> writes:

> On Wed, Jan 14, 2026, at 11:24, Toon Claes wrote:
>> Passing a tree OID to git-last-modified(1) would trigger BUG behavior.
>>
>>     git last-modified HEAD^{tree}
>>     BUG: builtin/last-modified.c:456: paths remaining beyond boundary
>> in last-modified
>>
>> Fix this error by verifying the parsed revision peels to a commit-ish.
>
> Nitpick: “peels to commit-ish” = commit-ish so this is a bit
> redundant. Either just “commit-ish” or “peels to commit” would be
> enough.
>
> s/verifying the parsed revision peels to a commit-ish./verifying that
> the parsed revision is a commit-ish./

Thanks! I've addressed this in v3.

>> While at it, also fix a memory leak in populate_paths_from_revs().
>
> (Whether or not this is a stale sentence (see Patricks’)) Why not a
> separate commit for fixing a memory leak?

Yeah, it's better to do that separately, so I've done so now.

-- 
Cheers,
Toon