From: Wincent Colaiuta Date: Fri, 02 Nov 2007 10:26:43 GMT Subject: Re: What's cooking in git.git (topics) Message-ID: <87F9D7C1-8E4D-4F74-B514-EF128189CB8A@wincent.com> In-Reply-To: <20071101214131.GF4099@lavos.net> El 1/11/2007, a las 22:41, Brian Downing escribió: > On Wed, Oct 31, 2007 at 10:41:06PM -0700, Junio C Hamano wrote: >> * jc/spht (Tue Oct 2 18:00:27 2007 -0700) 1 commit >> - git-diff: complain about >=8 consecutive spaces in initial indent >> >> This is a counterpart of an earlier patch from J. Bruce Fields >> to change "git-apply --whitespace" to make SP{8,} at the >> beginning of line a whitespace error. >> >> Personally, I am in favor of the stricter check, but I had to >> reject the "git-apply" patch because there was no way to disable >> the additional check without disabling the existing check for >> trailing whitespaces. We probably would want to revisit that >> one (perhaps with a new option and/or config to selectively >> enable different kinds of whitespace check). > > Just to throw in my two cents, I would be strongly opposed to this > going in without some form of configuration to make it work for > spaces-only-indent projects. Ditto, I also work on some projects which have a spaces-only policy, and the proposed change would be quite painful when working on those projects, so configurability would be very important to me. Cheers, Wincent