From: Ben Knoble <ben.knoble@gmail.com>
Date: Thu, 06 Nov 2025 14:07:06 GMT
Subject: Re: [PATCH] perl: also mark git-contacts executable
Message-ID: <87BB8F6A-7176-4C51-9F36-BA613E7D8B08@gmail.com>
In-Reply-To: <aQxMmnzPR6swvG-d@pks.im>



> Le 6 nov. 2025 à 02:22, Patrick Steinhardt <ps@pks.im> a écrit :
> 
> On Tue, Nov 04, 2025 at 01:14:57PM -0500, D. Ben Knoble wrote:
>> When install git-contacts with Meson via -Dcontrib=contacts, the default
> 
> s/install/installing/

Thanks. If Junio doesn’t mind the trivial fix, I’ll avoid sending v2 for now :)

> 
>> Perl generation fails to mark it executable. As a result, "git contacts"
>> reports "'contacts' is not a git command."
>> 
>> Unlike generate-script.sh, we aren't testing the basename here; so, glob
>> the script name in the case arm to match wherever the input comes from.
> 
> Yeah, that feels sensibel to me.
> 
>> diff --git a/generate-perl.sh b/generate-perl.sh
>> index 65f122ebfc..796d835932 100755
>> --- a/generate-perl.sh
>> +++ b/generate-perl.sh
>> @@ -30,7 +30,7 @@
>>     "$INPUT" >"$OUTPUT"
>> 
>> case "$INPUT" in
>> -*.perl)
>> +*.perl|*git-contacts)
>>    chmod a+x "$OUTPUT";;
>> *)
>>    ;;
> 
> And the change looks as expected. An alternative could of course be to
> rename the file in-tree to "git-contacts.perl". In that case we wouldn't
> require this special case at all. But I guess that this here is good
> enough, and there might be other consequences if we renamed the script.

My worry too. 

> Thanks!
> 
> Patrick

Thanks for the review!