From: Thomas Rast <trast@inf.ethz.ch>
Date: Fri, 03 Aug 2012 08:22:02 GMT
Subject: Re: [PATCH 05/16] t2104: Don't fail when index version is 5
Message-ID: <878vdwcrmd.fsf@thomas.inf.ethz.ch>
In-Reply-To: <1343905326-23790-6-git-send-email-t.gummerer@gmail.com>

Thomas Gummerer <t.gummerer@gmail.com> writes:

> The test t2104 currently checks if the index version is correctly
> reduced to 2/increased to 3, when an entry need extended flags,
> or doesn't use them anymore. Since index-v5 doesn't have extended
> flags (the extended flags are part of the normal flags), we simply
> add a check if the index version is 2/3 (whichever is correct for
> that test) or 5.

Next time we set a new index format as default (which might be when we
make v4 the default!), we'll have to patch this again.  Wouldn't it make
more sense to let them depend on a "default index format is v2"
prerequisite?

> -test_expect_success 'index is at version 2' '
> -	test "$(test-index-version < .git/index)" = 2
> +test_expect_success 'index is at version 2 or version 5' '
> +	test "$(test-index-version < .git/index)" = 2 ||
> +	test "$(test-index-version < .git/index)" = 5
>  '

-- 
Thomas Rast
trast@{inf,student}.ethz.ch