From: David Kastrup <dak@gnu.org>
Date: Tue, 04 Feb 2014 21:11:26 GMT
Subject: Re: [PATCH] blame.c: prepare_lines should not call xrealloc for every line
Message-ID: <878utqwpkx.fsf@fencepost.gnu.org>
In-Reply-To: <xmqqzjm67fpu.fsf@gitster.dls.corp.google.com>

Junio C Hamano <gitster@pobox.com> writes:

> David Kastrup <dak@gnu.org> writes:
>
>> Anybody know offhand what I should be including here?  It looks like Git
>> has some fallback definitions of its own, so it's probably not just
>> <string.h> I should include?
>
> In general, no *.c files outside the compatibility layer should
> include anything "#include <system-header.h>", as there seem to be
> finicky systems that care about order of inclusion and feature macro
> definitions, all of which are meant to be handled by including
> git-compat-util.h as the very first thing.

Ok, and that one's not yet in blame.c.  Will include, thanks.

-- 
David Kastrup