From: David Kastrup Date: Mon, 10 Mar 2014 09:08:41 GMT Subject: Re: [PATCH] simplified the chain if() statements of install_branch_config() function in branch.c Message-ID: <878usia09y.fsf@fencepost.gnu.org> In-Reply-To: Nemina Amarasinghe writes: >> >> Nemina Amarasinghe gmail.com> writes: >> >> Is it me, or is (origin || !origin) a tautology? >> > Thanks for the advices Matthieu. I will go through the documentations again. > Is there anything wrong with my logic? > What I wanted to express is > ((!remote_is_branch && origin) || (!remote_is_branch || !origin)) Is it? The above is the same as (!remote_is_branch || !origin). What you wrote before is the same as (!remote_is_branch). Maybe you should try copy&paste from the expressions you are trying to combine to make sure that what you start with makes sense. -- David Kastrup