From: Ævar Arnfjörð Bjarmason Date: Mon, 05 Mar 2018 21:33:13 GMT Subject: Re: [PATCH 2/2] add--interactive: detect bogus diffFilter output Message-ID: <878tb6nr6u.fsf@evledraar.gmail.com> In-Reply-To: <20180303055849.GB15952@sigill.intra.peff.net> On Sat, Mar 03 2018, Jeff King jotted: > + if (@colored && @colored != @diff) { nit: should just be: if (@colored != @diff) { It's not possible for @arrays in scalar context to be undefined.