From: Adrian Ratiu <adrian.ratiu@collabora.com>
Date: Wed, 10 Sep 2025 19:30:46 GMT
Subject: Re: [PATCH v2 06/10] submodule: encode gitdir paths to avoid conflicts
Message-ID: <878qim6r6h.fsf@collabora.com>
In-Reply-To: <aMHATMvn4Sdcz7mJ@szeder.dev>

On Wed, 10 Sep 2025, SZEDER Gábor <szeder.dev@gmail.com> wrote:
> On Mon, Sep 08, 2025 at 05:01:13PM +0300, Adrian Ratiu wrote: 
>> +	struct strbuf encoded_sub_name = STRBUF_INIT, tmp = 
>> STRBUF_INIT; +	size_t base_len, encoded_len; 
>>  	char *gitdir_path, *key; 
>> +	long name_max; 
> 
> Some of these new variables are not used or are only written: 
 
I moved the logic to a new commit but forgot to also move the 
variable definitions to the new commit. :)

Will fix this in v3, alongside running more tests & diagnostics on 
each commit to ensure they are also bisectable and so on.

Thanks for spotting this!