From: Thomas Rast <trast@inf.ethz.ch>
Date: Wed, 29 May 2013 08:25:03 GMT
Subject: Re: [PATCH v2 00/25] Remove assumptions about each_ref_fn arg lifetimes
Message-ID: <8761y2ura8.fsf@linux-k42r.v.cablecom.net>
In-Reply-To: <1369472904-12875-1-git-send-email-mhagger@alum.mit.edu>

Michael Haggerty <mhagger@alum.mit.edu> writes:

>

I read the entire series on Monday, and give it an Ack at maybe 90%
confidence level -- sorry, I was short on caffeine and sleep ;-)

I meant to verify this assertion:

> I did a manual audit of the 50 (!) functions that are used as an
> each_ref_fn callback to the for_each_ref()-style functions.  (I hope I
> haven't missed any.)  I checked that they do not make the assumption
> that the lifetimes of the refname and sha1 arguments extend past the
> duration of the callback invocation.  There were a number of callers
> that got this wrong; I believe I have fixed them all.

But time ran out, and I wouldn't want you to hold your breath.  The
series is a big improvement even if another caller slipped through the
cracks.

-- 
Thomas Rast
trast@{inf,student}.ethz.ch