From: Remi Galan Alfonso <remi.galan-alfonso@ensimag.grenoble-inp.fr>
Date: Sat, 06 Jun 2015 23:45:34 GMT
Subject: Re: [PATCH/RFCv2 2/2] git rebase -i: warn about removed commits
Message-ID: <876005532.186122.1433634334986.JavaMail.zimbra@ensimag.grenoble-inp.fr>
In-Reply-To: <1105867541.79324.1433362150592.JavaMail.zimbra@ensimag.grenoble-inp.fr>

I'm going to try to change the die_abort in this patch by a die, so
that the user can use rebase --edit-todo afterward. This way, adding
the checking on the SHA-1 for the 'drop' command (discussed in 1/2)
(and also maybe the other commands requiring a correct SHA-1
corresponding to a commit) to the 2/2 part would make a bit more
sense. Though I still see some other issues with this, I agree that it
makes more sense in 2/2 rather than in 1/2 (some more checking in a
future patch would be a good idea).

(So far I've tried rather quickly, but it doesn't seem as easy as I
originally though, working on it though)

Rémi