From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Wed, 17 Feb 2021 02:13:32 GMT
Subject: Re: [PATCH v2 09/27] userdiff tests: match full hunk headers
Message-ID: <875z2ra1bn.fsf@evledraar.gmail.com>
In-Reply-To: <xmqqim6rmox1.fsf@gitster.g>


On Wed, Feb 17 2021, Junio C Hamano wrote:

> Junio C Hamano <gitster@pobox.com> writes:
>
>> +		sed -ne "s/^@@[^@]*@@//p" actual |
>> +		if test -n "$HEAD"
>> +		then
>> +			grep -F "$HEAD"
>
> I think this should also use "-x" (match the whole line) if it is
> portable enough; the option should be available in POSIX.1 but we
> haven't used it anywhere in our test suite.

Isn't that just test_cmp with no debug output when it fails? Noted in
https://lore.kernel.org/git/87h7mba3h3.fsf@evledraar.gmail.com/

>> +		else
>> +			grep "^.*RIGHT"
>> +		fi
>> +	'
>>  done