From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Tue, 06 Jul 2021 20:12:15 GMT
Subject: Re: [RFC PATCH 10/35] update: add --ff option
Message-ID: <875yxn5hh2.fsf@evledraar.gmail.com>
In-Reply-To: <20210705123209.1808663-11-felipe.contreras@gmail.com>


On Mon, Jul 05 2021, Felipe Contreras wrote:

>  --------
>  linkgit:git-fetch[1], linkgit:git-fast-forward[1],
> diff --git a/builtin/update.c b/builtin/update.c
> index 1a69896aa8..34681fe21a 100644
> --- a/builtin/update.c
> +++ b/builtin/update.c
> @@ -7,12 +7,22 @@
>  #include "run-command.h"
>  #include "dir.h"
>  
> +enum update_mode_type {
> +	UPDATE_MODE_FAST_FORWARD = 0
> +};

Nit: If the value isn't important let's leave it out, also if you add a
trailing comma the subsequent commit where you add another value is less
churny. C supports that just fine.