From: Florian Weimer Date: Sun, 16 Sep 2007 20:20:06 GMT Subject: Re: [PATCH] New strbuf APIs: splice and attach. Message-ID: <874phugy6h.fsf@mid.deneb.enyo.de> In-Reply-To: <20070916172233.8B8AD1835F@madism.org> * Pierre Habouzit: > +void strbuf_grow(struct strbuf *sb, size_t extra) > +{ > if (sb->len + extra + 1 <= sb->len) > die("you want to use way too much memory"); By the way, this comparison is always false because sb->len is signed.