From: David Kastrup <dak@gnu.org>
Date: Mon, 10 Mar 2014 09:27:22 GMT
Subject: Re: [PATCH] simplified the chain if() statements of install_branch_config() function in branch.c
Message-ID: <874n369zet.fsf@fencepost.gnu.org>
In-Reply-To: <loom.20140310T101112-236@post.gmane.org>

Nemina Amarasinghe <neminaa@gmail.com> writes:

>> > ((!remote_is_branch && origin) || (!remote_is_branch || !origin))
>> 
>> Is it?
>> 
>> The above is the same as (!remote_is_branch || !origin).  What you wrote
>> before is the same as (!remote_is_branch).
>> 
>> Maybe you should try copy&paste from the expressions you are trying to
>> combine to make sure that what you start with makes sense.
>> 
> OMG.. Really sorry for that... that was a silly mistake. 
> This is the one..
>
> ((!remote_is_branch && origin) || (!remote_is_branch && !origin))

That is, indeed, perfectly equivalent to (!remote_is_branch).  If you
write

(!remote_is_branch && (origin || !origin))

then you will have people (and possibly also the compiler) loudly
wondering about what you are trying to say here.  The suspicion would be
that either this is a result of a typo or is supposed to be an
annoyingly obtuse replacement for a
/* TODO: treat origin and !origin differently */
kind of comment.

-- 
David Kastrup