From: Ævar Arnfjörð Bjarmason Date: Thu, 09 Sep 2021 08:06:24 GMT Subject: Re: [PATCH 0/9] packfile: avoid .idx rename races Message-ID: <874kauf9wq.fsf@evledraar.gmail.com> In-Reply-To: On Wed, Sep 08 2021, Taylor Blau wrote: > This series is a unification of [1] and [2] which together prevent a handful of > races when code that writes packfiles moves the `.idx` into place before all > other auxiliary files are properly renamed. > > This can lead to races like not reading the `.rev` file even if one was > generated and is about to be moved into place. > > Credit goes to Ævar for preparing what is more-or-less sent here. I polished a > few of the commit messages, and added the second patch on top of his result. It > isn't necessary, but felt like good hygiene when I was reading the surrounding > code. > > Thanks in advance for reviewing. Thanks a lot! I think it's probably redundant to note it at this point but I've given this a thorough review and it all looks good to me. I left some comments/musings on minor points in the series, but none of those IMO require a re-roll except perhaps the duplicate Signed-off-by headers, depending on what Junio thinks & if he's going to fix those while queuing.