From: Collin Funk <collin.funk1@gmail.com>
Date: Wed, 18 Jun 2025 20:37:42 GMT
Subject: Re: [PATCH] diff-no-index: do not reference .d_type member of struct dirent
Message-ID: <874iwcss4p.fsf@gmail.com>
In-Reply-To: <xmqqh60ces03.fsf@gitster.g>

Junio C Hamano <gitster@pobox.com> writes:

> Some platforms like AIX lack .d_type member in "struct dirent"; use
> the DTYPE(e) macro instead of a direct reference to e->d_type and
> when it yields DT_UNKNOWN, find the real type with get_dtype().
>
> Signed-off-by: Junio C Hamano <gitster@pobox.com>
> ---
>  * get_dtype() was designed for a typical
>
>     - prepare the path in a strbuf B
>     - opendir(B)
>     - loop over readdir(B)
>       - do things to path (B + e->d_name)
>
>    code structure, but because this code path does not use a strbuf
>    (instead the path given to opendir is a "const char *"), the
>    entire thing becomes messier than necessary.  get_dtype() has a
>    short-cut to avoid having to concatenate path+e->d_name and run
>    (l)stat() when e->d_type exists and known, but we need to open
>    code it here.
>
>  diff-no-index.c | 14 +++++++++++++-
>  1 file changed, 13 insertions(+), 1 deletion(-)

Tested on AIX 7.3 like the previous patch just to be safe and it works
as expected.

Reviewed-by: Collin Funk <collin.funk1@gmail.com>
Tested-by: Collin Funk <collin.funk1@gmail.com>

Thanks,
Collin