From: Pat Thoyts <patthoyts@users.sourceforge.net>
Date: Thu, 21 Oct 2010 23:42:52 GMT
Subject: Re: [PATCH] git-gui: apply color information from git diff
Message-ID: <8739rzf6yr.fsf@fox.patthoyts.tk>
In-Reply-To: <FB63A238-C5FD-4A00-9EAD-E99512C9D38B@sb.org>

Kevin Ballard <kevin@sb.org> writes:

>On Oct 21, 2010, at 8:22 AM, Pat Thoyts wrote:
>
>> +	while {[regexp -indices -start $start "\033\\\[(\\d+)?m" $line match code]} {
>
>Git currently doesn't emit combined escapes (e.g. \e[0;31m to reset and then turn on red text), but I can imagine it being enhanced to do this in the future. I would recommend handling it here if you can.

In fact that can be configured even now:
 % git config color.diff.whitespace "bold white bold cyan"
 % git diff --color | cat.exe --show-all
 ^[[1;37;46m+^[[m$
so thanks for the warning.
-- 
Pat Thoyts                            http://www.patthoyts.tk/
PGP fingerprint 2C 6E 98 07 2C 59 C8 97  10 CE 11 E6 04 E0 B9 DD