From: Thomas Rast Date: Fri, 18 May 2012 08:27:46 GMT Subject: Re: [PATCH v2] git-svn: clarify the referent of dcommit's optional argument Message-ID: <87396xj3lp.fsf@thomas.inf.ethz.ch> In-Reply-To: <7vliktfoza.fsf@alter.siamese.dyndns.org> Junio C Hamano writes: > Jon Seymour writes: > >> On Tue, May 15, 2012 at 2:16 AM, Junio C Hamano wrote: >>> >>> The only reason why the original is not ordered that way, as far as I can >>> tell, is because "It is recommended that" was part of an existing paragraph >>> when dd31da2 (git-svn: allow dcommit to take an alternate head, 2006-12-12) >>> added "An optional ...", so it was tucked after existing paragraph without >>> reading the resulting whole to see if "at the very end" was the best place. >> >> Re-reading this, I don't think the advice: >> >> "It is recommended that you run 'git svn' fetch and rebase (not >> pull or merge) your commits against the latest changes in the =C2=A0SVN >> repository." >> >> really belongs in the description of dcommit at all. > > I tend to agree. Opinions from git-svn experts? I agree that this is not dcommit-specific advice. Perhaps there should be a longer section that explains in detail what is rebased how and thus what the limitations of dcommit are. -- Thomas Rast trast@{inf,student}.ethz.ch