From: Thomas Rast Date: Tue, 19 Mar 2013 15:33:42 GMT Subject: Re: [PATCH] index-pack: always zero-initialize object_entry list Message-ID: <8738vr5rqh.fsf@pctrast.inf.ethz.ch> In-Reply-To: <20130319105852.GA15182@sigill.intra.peff.net> Jeff King writes: > Commit 38a4556 (index-pack: start learning to emulate > "verify-pack -v", 2011-06-03) added a "delta_depth" counter > to each "struct object_entry". Initially, all object entries > have their depth set to 0; in resolve_delta, we then set the > depth of each delta to "base + 1". Base entries never have > their depth touched, and remain at 0. This patch causes index-pack to fail on the pack that triggered the whole discussion. More in a minute in another side thread, but meanwhile: NAK until we understand what is really going on here. -- Thomas Rast trast@{inf,student}.ethz.ch