From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Thu, 06 Sep 2018 08:02:43 GMT
Subject: Re: [RFC PATCH 4/5] t1700-split-index: date back files to avoid racy situations
Message-ID: <871sa7rr30.fsf@evledraar.gmail.com>
In-Reply-To: <20180906024810.8074-5-szeder.dev@gmail.com>


On Thu, Sep 06 2018, SZEDER Gábor wrote:

> +# Create a file named as $1 with content read from stdin.
> +# Set the file's mtime to a few seconds in the past to avoid racy situations.
> +create_file () {

Nit: Would be easier to read in the future as
e.g. s/create_file/create_old_file/ or something like that. I.e. so you
can see at a glance from the tests themselves what this is doing.

>  test_expect_success 'modify original file, base index untouched' '
> -	echo modified >one &&
> +	echo modified |create_file one &&

Style nit: missing whitespace after "|", i.e. should be "echo modified |
create_file one".