From: Sergey Organov <sorganov@gmail.com>
Date: Thu, 20 May 2021 19:38:40 GMT
Subject: Re: [PATCH 6/6] diff-merges: let -m imply -p
Message-ID: <871ra1b3gf.fsf@osv.gnss.ru>
In-Reply-To: <YKaverOKIAJpJl3s@google.com>

Jonathan Nieder <jrnieder@gmail.com> writes:

> Sergey Organov wrote:
>> Junio C Hamano <gitster@pobox.com> writes:
>
>>> This is about "log" from the "rev-list" family, not "diff" to
>>> compare two endpoints, so "git diff" won't be affected, and "git
>>> diff-tree" is not affected, either.
>>
>> You are right. I've added a test for "git diff-tree -m", and the changes
>> don't break it.
>
> Good.
>
>> Can easily re-roll if you think the test worth it.
>
> I care more about the commit message than the test --- i.e. mentioning
> that this doesn't affect commands like
>
> 	git rev-list HEAD~5..HEAD | git diff-tree --stdin -m

OK, re-roll to follow...

Thanks,
-- Sergey Organov