From: Toon Claes <toon@iotcl.com>
Date: Fri, 25 Apr 2025 11:24:19 GMT
Subject: Re: [PATCH v2 0/2] meson: prefer '/bin/sh' over PATH lookup
Message-ID: <871ptgfpr0.fsf@iotcl.com>
In-Reply-To: <20250425-pks-meson-posix-shell-v2-0-fddc6123511b@pks.im>

Patrick Steinhardt <ps@pks.im> writes:

> Hi,
>
> at GitLab, we recently got a couple of bug reports about Git not being
> able to find its shell anymore. The root cause is that with Meson we
> have started to look up the shell via PATH, which may exist on the build
> host, but not on the target host. We have worked around this issue with
> a cross file:
>
>     $ cat >cross.ini <<-EOF
>     [binaries]
>     sh = '/bin/sh'
>     EOF
>     $ meson setup build --cross-file=./cross.ini
>
> But this made me remember the report from Peter [1] that Debian also
> faced this issue. So I decided to address the issue in Meson directly by
> preferring `/bin/sh` over a PATH-based lookup.
>
> Changes in v2:
>   - Simplify how we generate the summary.
>   - Add a comment to explain ordering of the program path.
>   - Link to v1: https://lore.kernel.org/r/20250424-pks-meson-posix-shell-v1-0-45e06ee4b6ad@pks.im
>
> Thanks!
>
> Patrick

Reviewed and looks good to me. It behaves as explained, although I don't
know how to easily test the original error we've been seeing.

-- 
Toon