From: phillip.wood123@gmail.com Date: Wed, 13 Mar 2024 15:10:02 GMT Subject: Re: [PATCH v3 4/7] sequencer: treat error reading HEAD as unborn branch Message-ID: <87155d50-40b8-4394-99f3-5194d7da785a@gmail.com> In-Reply-To: <20240310184602.539656-5-brianmlyles@gmail.com> Hi Brian On 10/03/2024 18:42, Brian Lyles wrote: > - Avoid using `--quiet` in the `git diff` call to make debugging easier > in the event of a failure Sorry, I forgot when I was reviewing v2 that we need to replace --quiet with --exit-code otherwise the diff will never fail. Apart from that I don't have anything to add to Junio's comments on this patch. Best Wishes Phillip