From: Jakub Narebski <jnareb@gmail.com>
Date: Sun, 08 Apr 2018 12:59:57 GMT
Subject: Re: [PATCH v7 08/14] commit-graph: implement git commit-graph read
Message-ID: <86woxhdfaq.fsf@gmail.com>
In-Reply-To: <20180402203427.170177-9-dstolee@microsoft.com>

Derrick Stolee <stolee@gmail.com> writes:

[...]
>  EXAMPLES
>  --------
> @@ -45,6 +51,12 @@ EXAMPLES
>  $ git commit-graph write
>  ------------------------------------------------
>  
> +* Read basic information from the commit-graph file.
> ++
> +------------------------------------------------
> +$ git commit-graph read
> +------------------------------------------------

It would be better to have example output of this command here, perhaps
together with ASCII-art diagram of the code graph.

[...]
> +	if (!graph)
> +		die("graph file %s does not exist", graph_name);
> +	FREE_AND_NULL(graph_name);

Shouldn't the error message be marked up for translation, too?

Regards,
-- 
Jakub Narębski