From: Jakub Narebski Date: Mon, 30 Dec 2019 20:30:30 GMT Subject: Re: [PATCH 03/16] t2018: use test_must_fail for failing git commands Message-ID: <86lfqt36ah.fsf@gmail.com> In-Reply-To: Denton Liu writes: > While we're at it, remove redirections to /dev/null since output is > silenced when running without `-v` and debugging output is useful with > `-v`, remove redirections to /dev/null as it is not useful. ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Very minor nit: The underlined part (after last comma) duplicates what already has been said. -- Jakub Narębski