From: Sebastian Schuberth Date: Wed, 10 May 2017 18:55:19 GMT Subject: Re: [PATCH] fetch-pack: always allow fetching of literal SHA1s Message-ID: <86ede049-ac9e-0886-acde-42e53ef30243@gmail.com> In-Reply-To: <20170510170044.GX28740@aiede.svl.corp.google.com> On 2017-05-10 19:00, Jonathan Nieder wrote: >> Right, makes sense. I wondered if GitHub should be turning on >> allowTipSHA1InWant, but it really doesn't make sense to. We _do_ hide >> some internal refs[1], and they're things that users wouldn't want to >> fetch. The problem for your case really is just on the client side, and >> this patch fixes it. > [...] >> [1] The reachability checks from upload-pack don't actually do much on >> GitHub, because you can generally access the objects via the API or >> the web site anyway. So I'm not really opposed to turning on >> allowTipSHA1InWant if it would be useful for users, but after >> Jonathan's patch I don't see how it would be. > > Given that, what would make me really happy is if github enables > uploadpack.allowAnySHA1InWant. That would be useful for me, at least. Me too, BTW. If you're only interested in building / analyzing a specific SHA1 it's really a waste of network resources to fetch all of the history. -- Sebastian Schuberth