From: David Kastrup Date: Mon, 13 Aug 2007 10:23:16 GMT Subject: Re: [PATCH] diff: don't run pager if user asked for a diff style exit code Message-ID: <86d4xrka23.fsf@lola.quinscape.zz> In-Reply-To: <13516449-DEDB-41A1-8880-42CB124A6C0A@wincent.com> Wincent Colaiuta writes: > El 12/8/2007, a las 19:46, René Scharfe escribió: > >> Push pager setup down into builtin-diff.c and don't start the pager >> if --exit-code or --quiet (which implies --exit-code) was specified. > > Great stuff, René. The change looks much simpler than I thought it > would. Personally, I'd start the pager only when the first diff or stat gets output, anyway. For a summary message or even a silent exit, a pager is annoying, regardless of whether --exit-code was specified. -- David Kastrup