From: David Kastrup <dak@gnu.org>
Date: Mon, 15 Oct 2007 14:03:23 GMT
Subject: Re: [PATCH 2/3] Quoting paths in tests
Message-ID: <86d4vgmq50.fsf@lola.quinscape.zz>
In-Reply-To: <47136F71.1050107@viscovery.net>

Johannes Sixt <j.sixt@viscovery.net> writes:

> Jonathan del Strother schrieb:
>> -	svn import -m 'import for git-svn' . $svnrepo >/dev/null &&
>> +	svn import -m 'import for git-svn' . '$svnrepo' >/dev/null &&
>>  	cd .. &&
>>  	rm -rf import &&
>> -	git-svn init $svnrepo"
>> +	git-svn init '$svnrepo'"
>
> I don't see the point in changing an incorrect quoting to a different
> incorrect quoting that you fix up in a follow-up patch. It's *two*
> large patches to review instead of just one. I'm stopping the review
> here.

Since I consider it unlikely that Jonathan is making your life harder
on purpose, it might be somewhat more helpful to offer submission
advice:

Jonathan, try

git rebase -i HEAD~3

or so in order to consolidate the last 3 patches you did.  Interactive
rebase is one useful manner of munging history until it looks
reasonably nice for submission.  One major point of git's distributed
operation is that one can clean up the development history locally
before handing things out.

That makes the project repositories cleaner to understand.

-- 
David Kastrup