From: David Kastrup Date: Fri, 16 Jan 2009 13:22:20 GMT Subject: Re: [PATCH] revision walker: include a detached HEAD in --all Message-ID: <868wpbmlmb.fsf@lola.quinscape.zz> In-Reply-To: Johannes Schindelin writes: > On Fri, 16 Jan 2009, Santi Béjar wrote: > >> 2009/1/16 Johannes Schindelin : >> > >> > Note that this affects creating bundles with --all; I contend that it >> > is a good change to add the HEAD, so that cloning from such a bundle >> > will give you a current branch. However, I had to fix t5701 as it >> > assumed that --all does not imply HEAD. >> >> From the description I understand that it only affects when the HEAD is >> detached, but in t5701 the HEAD is not detached so nothing should be >> fixed. > > The error in t5701 was that it _wanted_ to test a bundle without a HEAD, > but it actually created it with --all. That was implying that --all does > not mean HEAD, and I disagree with that. I don't think that a detached HEAD should be a special case, since you can have other detached symbolic references no longer on a branch. None of those should be garbage-collected either, I think. -- David Kastrup