From: Randal L. Schwartz <merlyn@stonehenge.com>
Date: Thu, 26 Apr 2007 02:11:48 GMT
Subject: Re: [PATCH] git-svn: Don't rely on $_ after making a function call
Message-ID: <864pn3hokb.fsf@blue.stonehenge.com>
In-Reply-To: <7v4pn4w41k.fsf@assigned-by-dhcp.cox.net>

>>>>> "Junio" == Junio C Hamano <junkio@cox.net> writes:

Junio> I suspect Merlyn has better explanation, but...

Junio>      for (list) {
Junio> 	...	
Junio>      }

Junio> loop implicitly localizes $_ and does not share this problem,
Junio> which I really appreciate whenever I am writing Perl code, but
Junio> often enough I was bitten by scripts that use "while (<$fh>)",
Junio> which does not localizes $_, and made hard to spot bugs by
Junio> clobbering $_.

Junio> I find the patch a good safety measure for any future breakages.

I'm happy with the patch.

-- 
Randal L. Schwartz - Stonehenge Consulting Services, Inc. - +1 503 777 0095
<merlyn@stonehenge.com> <URL:http://www.stonehenge.com/merlyn/>
Perl/Unix/security consulting, Technical writing, Comedy, etc. etc.
See PerlTraining.Stonehenge.com for onsite and open-enrollment Perl training!