From: David Kastrup Date: Mon, 06 Aug 2007 16:16:42 GMT Subject: Re: [PATCH] Add --show-touched option to show "diff --git" line when contents are unchanged Message-ID: <864pjcbpud.fsf@lola.quinscape.zz> In-Reply-To: <86bqdkbq59.fsf@lola.quinscape.zz> David Kastrup writes: > I don't even think it prudent to _offer_ the --show-touched option > in a porcelain such as git-diff as long as purportedly read-only > porcelain commands like git-status can trash the state: what is > reported is not actually "touched" but something internal to the > operation of git. > > At least not without a notice in the manual that this option might > or might not work, depending on what one did previously. Proposal: if this option is to stay, call it rather --show-stale since that corresponds better with what the option actually does: show whether git's inode cache went stale. It does _not_ show whether the file has been touched (git-status does not touch files, for example). -- David Kastrup