From: David Kastrup Date: Sat, 29 Sep 2007 12:52:36 GMT Subject: Re: [PATCH 1/1] --color and --no-color git-log options don't need diffs to be computed. Message-ID: <85ve9t8wh7.fsf@lola.goethe.zz> In-Reply-To: <20070929123724.01BB045EC@madism.org> Pierre Habouzit writes: > Signed-off-by: Pierre Habouzit > - if (strcmp(argv[i], "-z")) > - revs->diff = 1; > + revs->diff = strcmp(argv[i], "-z") > + && strcmp(argv[i], "--color") > + && strcmp(argv[i], "--no-color"); > i += opts - 1; > continue; This can clear a previously set value of revs->diff. -- David Kastrup, Kriemhildstr. 15, 44793 Bochum