From: David Kastrup <dak@gnu.org>
Date: Wed, 17 Oct 2007 20:03:10 GMT
Subject: Re: [PATCH 2/2] Quoting paths in tests
Message-ID: <85sl49ecg1.fsf@lola.goethe.zz>
In-Reply-To: <864pgpfyrd.fsf@lola.quinscape.zz>

David Kastrup <dak@gnu.org> writes:

> Jonathan del Strother <maillist@steelskies.com> writes:
>
>> For instance, git_editor in git-sh-setup expects the editor path to be
>> pre-quoted.  So in t3404, you need to produce escaped double quotes &
>> dollar signs, resulting in unpleasantness like this :
>>
>> VISUAL="`pwd`/fake-editor.sh"
>> VISUAL=${VISUAL//\"/\\\"}
>> VISUAL=${VISUAL//$/\\\$}
>> VISUAL=\"$VISUAL\"
>> export VISUAL
>
> EDITORPWD="`pwd`"
> VISUAL='$EDITORPWD/fake-editor.sh'
> export EDITORPWD VISUAL

Pffffft.

VISUAL='"$EDITORPWD/fake-editor.sh"'

of course.  Or we still have problems with spaces in pwd.

-- 
David Kastrup, Kriemhildstr. 15, 44793 Bochum