From: David Kastrup Date: Wed, 28 Nov 2007 14:24:19 GMT Subject: Re: [PATCH] Replace instances of export VAR=VAL with VAR=VAL; export VAR Message-ID: <85lk8ia1nw.fsf@lola.goethe.zz> In-Reply-To: "Nguyen Thai Ngoc Duy" writes: > On Nov 28, 2007 8:57 PM, Johannes Schindelin wrote: >> >> It might be POSIX, but there are shells that do not like the >> expression 'export VAR=VAL'. To be on the safe side, rewrite them >> into 'VAR=VAL' and 'export VAR'. > > Why leave test scripts behind? Good keyword: how about starting the basic tests by testing for shell features that are known and accepted to be used in git? That way, we get direct feedback when feature assumptions are problematic with some shells. -- David Kastrup, Kriemhildstr. 15, 44793 Bochum