From: David Kastrup Date: Thu, 15 Nov 2007 01:21:44 GMT Subject: Re: [PATCH] Fix Solaris Workshop Compiler issues Message-ID: <85ir441exj.fsf@lola.goethe.zz> In-Reply-To: Linus Torvalds writes: > On Wed, 14 Nov 2007, Junio C Hamano wrote: >> >> Maybe your compiler needs -DFLEX_ARRAY=0 in CFLAGS? > > Actually, for old pre-C99 compilers, you're probably better off using > -DFLEX_ARRAY=1, since a zero-sized array could be considered bogus by > some. Is that supposed to work? I would have thought that the only options would be empty and 0. I am pretty sure I have seen size calculations in the deltifying code that would break badly using FLEX_ARRAY=1. So _IFF_ -DFLEX_ARRAY=1 is supposed to be necessary for some compilers, I could try seeing whether I find those locations again. -- David Kastrup, Kriemhildstr. 15, 44793 Bochum