From: David Kastrup <dak@gnu.org>
Date: Wed, 28 Nov 2007 14:41:07 GMT
Subject: Re: [PATCH] Replace instances of export VAR=VAL with VAR=VAL; export VAR
Message-ID: <85aboya0vw.fsf@lola.goethe.zz>
In-Reply-To: <Pine.LNX.4.64.0711281428180.27959@racer.site>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

> On Wed, 28 Nov 2007, Johannes Sixt wrote:
>
>> Johannes Schindelin schrieb:
>> > -			s/.*/export GIT_'$uid'_NAME='\''&'\''/p
>> > +			s/.*/GIT_'$uid'_NAME='\''&'\''\nexport
>> > GIT_'$uid'_NAME/p
>> 
>> Recently there was a report that \n in the substitution side of s/// is not
>> supported by all seds :-(
>
> Okay, how about replacing the line with
>
> +			s/.*/GIT_'$uid'_NAME='\''&'\''\
> +export GIT_'$uid'_NAME/p
>
> Hmm?  (It works here.)

Do we really want to replace code which is not as far as I know known to
fail under any of the supported shells with something which quite
possibly relies on particular sed implementations (and we have fewer
portability guarantees or even experience about sed than about the
shell, right?)?

-- 
David Kastrup, Kriemhildstr. 15, 44793 Bochum