From: David Kastrup Date: Sat, 11 Aug 2007 12:12:54 GMT Subject: Re: [fixed PATCH] git-filter-branch.sh: Fix broken setting of GIT_DIR Message-ID: <858x8iw9q1.fsf@lola.goethe.zz> In-Reply-To: <85r6mawedp.fsf@lola.goethe.zz> David Kastrup writes: > Anyway, if $GIT_DIR is a relative path, things would go wrong in some > lines earlier, and if GIT_DIR were used or exported which it isn't, so we are lucky... > where the path is already being changed. > > If git-sh-setup sets GIT_DIR, perhaps it would be sanest if it also > made it absolute? > > Otherwise any script that does "cd" will lose track of GIT_DIR, right? Actually, wouldn't by far the most straightforward thing be if git-rev-parse --git-dir always returned an absolute path (even when being passed a relative path in GIT_DIR)? No need for postprocessing, no need to keep track of changed directories. -- David Kastrup, Kriemhildstr. 15, 44793 Bochum